Add vertical offset parameter to the No Sync filter

mltframework · Jan 21, 2025 · 753fa37 · 753fa37
1 parent 3116a70
commit 753fa37
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 9 deletions.
diff --git a/src/qml/filters/nosync/meta.qml b/src/qml/filters/nosync/meta.qml
@@ -13,14 +13,21 @@ Metadata {
     keyframes {
         allowAnimateIn: true
         allowAnimateOut: true
-        simpleProperties: ['0']
+        simpleProperties: ['0', '1']
         parameters: [
             Parameter {
-                name: qsTr('Offset')
+                name: qsTr('H Offset')
                 property: '0'
                 isCurve: true
                 minimum: 0
                 maximum: 1
+            },
+            Parameter {
+                name: qsTr('V Offset')
+                property: '1'
+                isCurve: true
+                minimum: 0
+                maximum: 1
             }
         ]
     }

diff --git a/src/qml/filters/nosync/ui.qml b/src/qml/filters/nosync/ui.qml
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019-2022 Meltytech, LLC
+ * Copyright (c) 2019-2024 Meltytech, LLC
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -22,34 +22,41 @@ import Shotcut.Controls as Shotcut
 Shotcut.KeyframableFilter {
     property string horizontal: '0'
     property double horizontalDefault: 0.2
+    property string vertical: '1'
+    property double verticalDefault: 0.0
 
     function setControls() {
         var position = getPosition();
         blockUpdate = true;
         horizontalSlider.value = filter.getDouble(horizontal, position) * horizontalSlider.maximumValue;
         horizontalKeyframesButton.checked = filter.animateIn <= 0 && filter.animateOut <= 0 && filter.keyframeCount(horizontal) > 0;
+        verticalSlider.value = filter.getDouble(vertical, position) * verticalSlider.maximumValue;
+        verticalKeyframesButton.checked = filter.animateIn <= 0 && filter.animateOut <= 0 && filter.keyframeCount(vertical) > 0;
         blockUpdate = false;
         enableControls(isSimpleKeyframesActive());
     }
 
     function enableControls(enabled) {
         horizontalSlider.enabled = enabled;
+        verticalSlider.enabled = enabled;
     }
 
     function updateSimpleKeyframes() {
         setControls();
         updateFilter(horizontal, horizontalSlider.value / horizontalSlider.maximumValue, horizontalKeyframesButton, null);
+        updateFilter(vertical, verticalSlider.value / verticalSlider.maximumValue, verticalKeyframesButton, null);
     }
 
-    keyframableParameters: [horizontal]
-    startValues: [0]
-    middleValues: [horizontalDefault]
-    endValues: [0]
+    keyframableParameters: [horizontal, vertical]
+    startValues: [0, 0]
+    middleValues: [horizontalDefault, verticalDefault]
+    endValues: [0, 0]
     width: 350
     height: 100
     Component.onCompleted: {
         if (filter.isNew) {
             filter.set(horizontal, horizontalDefault);
+            filter.set(vertical, verticalDefault);
             filter.savePreset(preset.parameters);
         }
         setControls();
@@ -68,10 +75,11 @@ Shotcut.KeyframableFilter {
         Shotcut.Preset {
             id: preset
 
-            parameters: [horizontal]
+            parameters: [horizontal, vertical]
             Layout.columnSpan: 3
             onBeforePresetLoaded: {
                 filter.resetProperty(horizontal);
+                filter.resetProperty(vertical);
             }
             onPresetSelected: {
                 setControls();
@@ -80,7 +88,7 @@ Shotcut.KeyframableFilter {
         }
 
         Label {
-            text: qsTr('Offset')
+            text: qsTr('Horizontal Offset')
             Layout.alignment: Qt.AlignRight
         }
 
@@ -108,6 +116,35 @@ Shotcut.KeyframableFilter {
             }
         }
 
+        Label {
+            text: qsTr('Vertical Offset')
+            Layout.alignment: Qt.AlignRight
+        }
+
+        Shotcut.SliderSpinner {
+            id: verticalSlider
+
+            minimumValue: 0
+            maximumValue: 100
+            stepSize: 0.01
+            decimals: 2
+            suffix: ' %'
+            onValueChanged: updateFilter(vertical, verticalSlider.value / verticalSlider.maximumValue, verticalKeyframesButton, getPosition())
+        }
+
+        Shotcut.UndoButton {
+            onClicked: verticalSlider.value = verticalDefault * verticalSlider.maximumValue
+        }
+
+        Shotcut.KeyframesButton {
+            id: verticalKeyframesButton
+
+            onToggled: {
+                enableControls(true);
+                toggleKeyframes(checked, vertical, verticalSlider.value / verticalSlider.maximumValue);
+            }
+        }
+
         Item {
             Layout.fillHeight: true
         }