feat(table): improve pretty-printing for simple tables and lists #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR improves the pretty printing code for Lua tables:
["hello"] = 3
) as justhello = 3
The use case for this is reading in a Lua file (like a rockspec), modifying its globals and then reconstructing the Lua file in a readable format. Given that debug pretty printing is for debugging (duh), I'm not classifying this as any sort of breaking change :)
One note: the
is_sequence
check goes through all keys in a table and checks if they're integers and in ascending order. Theis_list()
method is only forcfg!(serialize)
, so I've refrained from refactoring that in fear of breaking some obscure behaviour. Let me know if there's anything you'd change!