chore: explore migration from jest to vitest #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackage for esm+cjs. This PR is the initial setup/migration to the new bundler + testing framework. Overall, vitest was a simple setup but rollup was encountering cyclical dependency issues, so a minor extraction of various functions to separate files was needed. _Note: All moved functions that were originally exposed via API to end-user developers have remained the same._ Additional changes: - `require` is now `await import` which required `createTargets` to be migrated to `async`. This was fine as the caller of `createTargets` is already an async function, so this simply was a matter of adding `await` to `createTargets` invocation - `ifAll` test helper function was removed. It would be triggered via env var ALL_TESTS, but we haven't used that env var in years. - Added ts-node to run `checkDeps` and `generate-schema` since we don't compile the `test` dir with rollup, vitest automatically is able to run it as-is.
…vitest-rollup-2 # Conflicts: # test/src/HoistedNodeModuleTest.ts
…vitest-rollup-5 # Conflicts: # rollup.config.ts
# Conflicts: # packages/app-builder-lib/src/index.ts # packages/app-builder-lib/src/packager.ts # packages/app-builder-lib/src/platformPackager.ts # packages/app-builder-lib/src/publish/PublishManager.ts # packages/builder-util/src/DebugLogger.ts # packages/electron-builder-squirrel-windows/src/SquirrelWindowsTarget.ts # test/src/HoistedNodeModuleTest.ts # test/src/globTest.ts # test/src/helpers/CheckingPackager.ts # test/src/windows/squirrelWindowsTest.ts
…vitest-tsc # Conflicts: # pnpm-lock.yaml # test/package.json # test/src/HoistedNodeModuleTest.ts # test/src/globTest.ts # test/src/helpers/packTester.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.