forked from facebookarchive/draft-js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade eslint + flow, and fix failed test from nullishCoalescingOper…
…ator (facebookarchive#2083) Summary: **Summary** I want to upgrade ESLint and Flow on this project. I ended up with - Remove unused `eslint-plugin-relay` - Upgrade all ESLint packages to the latest version and fix all the new lint errors afterward. - `eslint-config-fbjs` - `eslint-config-prettier` - `eslint-plugin-babel` - `eslint-plugin-flowtype` - `eslint-plugin-jsx-a11y` - `eslint-plugin-prettier` - `eslint-plugin-react` - Upgrade Flow (`flow-bin`) to the `0.115.0`. ~Then I found that `yarn test` is failing at~ ``` src/component/handlers/composition/__tests__/DraftEditorCompostionHandler-test.js: Support for the experimental syntax 'nullishCoalescingOperator' isn't currently enabled (70:40) ``` ~So I added `babel/plugin-proposal-nullish-coalescing-operator` to jest preprocessor as well.~ Move plugins in `.babelrc` to jest preprocessor as facebookarchive#2083 (comment) **Test Plan** `yarn lint`, `yarn flow`, and `yarn test` should all pass. Pull Request resolved: facebookarchive#2083 Reviewed By: claudiopro Differential Revision: D19398251 Pulled By: mrkev fbshipit-source-id: 4fc2f6dd6e0cd44266d061455b7b6a433231715a
- Loading branch information
Showing
8 changed files
with
171 additions
and
87 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,4 +50,4 @@ unsafe-getters-setters | |
; nonstrict-import | ||
|
||
[version] | ||
^0.110.1 | ||
^0.115.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters