Skip to content

Commit

Permalink
Do not attempt to sign .cat files (dotnet#190)
Browse files Browse the repository at this point in the history
.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
  • Loading branch information
mmitche committed Aug 23, 2022
1 parent 3f6c45a commit 61b470e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
<FileExtensionSignInfo Update="@(FileExtensionSignInfo)" CertificateName="3PartySHA2" />
<FileExtensionSignInfo Update=".nupkg" CertificateName="NuGet" />
<FileExtensionSignInfo Update=".zip" CertificateName="None" />
<FileExtensionSignInfo Include=".cat" CertificateName="3PartySHA2" />
<FileExtensionSignInfo Include=".msi" CertificateName="Microsoft400" />
<FileExtensionSignInfo Include=".msi" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Include=".pyd" CertificateName="3PartySHA2" />

<!--
Expand Down

0 comments on commit 61b470e

Please sign in to comment.