-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIDS sample
and value
columns will be considered "arbitrary" columns soon
#1130
Milestone
Comments
thanks for the update. I guess we will need a few PRs :)
…On Tue, Apr 11, 2023 at 3:10 PM Stefan Appelhoff ***@***.***> wrote:
as discussed in:
- bids-standard/bids-specification#1441
<bids-standard/bids-specification#1441>
and implemented in:
- bids-standard/bids-specification#1457
<bids-standard/bids-specification#1457>
the currently OPTIONAL sample and value columns in *_events.tsv files
will be demoted to "arbitrary" columns in BIDS 1.9.0.
Practically this means, that mne-bids should write entries into
*_events.json, defining how *we* use sample and value.
Otherwise, datasets produced by mne-bids might soon generate a "warning"
(not an error 😉 ) that sample and value are undefined.
—
Reply to this email directly, view it on GitHub
<#1130>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHKHHEE3HYBPICN5GDB7LXAVJ3VANCNFSM6AAAAAAW2IHALQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 22, 2023
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 22, 2023
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 23, 2023
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 23, 2023
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 23, 2023
hoechenberger
added a commit
to hoechenberger/mne-bids
that referenced
this issue
Apr 23, 2023
sappelhoff
added a commit
that referenced
this issue
Apr 25, 2023
…es (#1132) Write events.json with "sample", "value", and "trial_type" entries Fixes #1130 Co-authored-by: Stefan Appelhoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
as discussed in:
and implemented in:
sample
andvalue
columns inevents.tsv
from OPTIONAL to arbitrary bids-standard/bids-specification#1457the currently OPTIONAL
sample
andvalue
columns in*_events.tsv
files will be demoted to "arbitrary" columns in BIDS 1.9.0.Practically this means, that
mne-bids
should write entries into*_events.json
, defining how we usesample
andvalue
.Otherwise, datasets produced by mne-bids might soon generate a "warning" (not an error 😉 ) that
sample
andvalue
are undefined.The text was updated successfully, but these errors were encountered: