ENH: Overlap-add filtering for long signals #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it make sense to pass a filter length to the *_filter functions to let users specify the frequency resolution they want (like mne_process_raw does) something like: where XXX is None means use full signal FFT or XXX=4096 means use overlap add with buffers of size 4096. It seems like exposing the N_fft parameter (that btw should be nfft or n_fft) |
|
Improved code based on your comments. The test now compares direct filtering and overlap-add filtering. Note that due to the different types of convolution (circular and linear with mirrored boundary), the edges of the filtered signal are slightly different. I don't think it is possible to avoid this. |
| # response | ||
| n_edge = min(n_h, len(x)) | ||
|
|
||
| x_ext = np.r_[2 * x[0] - x[n_edge - 1:0:-1],\ |
There was a problem hiding this comment.
you don't need the \ in parenthesis
larsoner
added a commit
that referenced
this pull request
Feb 5, 2013
ENH: adding a test for channels / bads mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added zero-phase overlap-add filtering for signals longer than 60s (direct FFT filtering is faster for shorter signals). Unified filter function for low/high/band - pass.