Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Show contributor image on homepage #11819

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

larsoner
Copy link
Member

I saw this over on https://github.com/conda-incubator/setup-miniconda#contributors and thought it was neat, thought we might consider adding something similar. It ends up looking like this currently:

Screenshot from 2023-07-20 14-50-39

@cbrnr
Copy link
Contributor

cbrnr commented Jul 20, 2023

Looks good! I guess this won't be enough to convince everyone that this resolves #11605?

@larsoner
Copy link
Member Author

I think the larger issues there would remain unresolved even if we add this

@drammock
Copy link
Member

I have somewhat mixed feelings. It seems nice to include this content on the homepage, but I'm a bit sad that the result comes as a pre-built SVG without control over the layout (i.e. number of columns; I'm assuming it will look pretty bad on mobile as a result --- @larsoner did you check that?)

Can we leave this as draft for a week, and if I haven't managed to home-build something better that is layout-responsive, then we can just go with this one (assuming it's not too terrible on mobile)?

@larsoner
Copy link
Member Author

I'm assuming it will look pretty bad on mobile as a result --- @larsoner did you check that?)

I hadn't, but I think it's okay -- you can tell that there are people which seems reasonable for a mobile view. Here's Google's GS20Ultra interpretation:

Screenshot from 2023-07-20 16-21-50

But what I actually see on my phone is a bit nicer actually, I can recognize some people at least :)

a

@larsoner
Copy link
Member Author

@drammock also feel free to tweak any CSS or whatever, push, and merge when you're happy

@larsoner larsoner marked this pull request as ready for review July 20, 2023 21:01
@drammock
Copy link
Member

OK that took a tad longer than I hoped, but 50 lines of javascript and the GitHub API got the job done. Now it's responsive to screen width (and if we want we can customize the avatar size or add other styling)

@drammock
Copy link
Member

(as an added bonus, this now shows all contribs, not just the top 100)

@larsoner larsoner merged commit 7b23048 into mne-tools:main Jul 21, 2023
@larsoner
Copy link
Member Author

Thanks @drammock !

@larsoner larsoner deleted the contrib branch July 21, 2023 00:21
@cbrnr
Copy link
Contributor

cbrnr commented Jul 21, 2023

Very cool @drammock!

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants