MAINT: Post-release deprecations #12265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
wmvanvliet,
drammock,
dengemann,
adam2392,
mscheltienne,
cbrnr and
agramfort
as code owners
larsoner
commented
Dec 4, 2023
| @@ -322,12 +322,11 @@ def __init__( | |||
| # don't allow complex output | |||
| psd_funcs = dict(welch=psd_array_welch, multitaper=psd_array_multitaper) | |||
| if method_kw.get("output", "") == "complex": | |||
| warn( | |||
There was a problem hiding this comment.
@drammock wasn't sure if there was additional code we could remove from spectrum now that we do not support complex output. Can you push if so?
There was a problem hiding this comment.
ha, luckily I had kept the old branch around so I just had to cherry-pick and resolve a couple small conflicts
larsoner
removed request for
agramfort,
wmvanvliet,
dengemann,
adam2392,
cbrnr and
mscheltienne
|
hmm circleci and pip-pre are failing at check-Qt step, and ultraslow is failing at |
|
Need a merge with main which I'll do now |
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Dec 5, 2023
* upstream/main: MRG: Use ruff-format instead of Black (mne-tools#12261) MAINT: Make selenium optional and use on CircleCI (mne-tools#12263) MAINT: Post-release deprecations (mne-tools#12265) MAINT: Replace `Path.parent.parent` with `Path.parents[N]` in tests (mne-tools#12257)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: Daniel McCloy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.