Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement picks argument to Raw.plot() #12467

Merged
merged 21 commits into from
Apr 15, 2024
Merged

Implement picks argument to Raw.plot() #12467

merged 21 commits into from
Apr 15, 2024

Conversation

ivopascal
Copy link
Contributor

Implements #12355

An arguments picks is added to Raw.plot() to offer it the same functionality as Epochs.plot() and Evoked.plot().

Picks selects a subset of channels to be visualised, but ignores the order of them. order= does specify the sequence. Any interactions are resolved in the same way as Epochs.plot().

Copy link

welcome bot commented Feb 29, 2024

Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴

@ivopascal ivopascal marked this pull request as draft February 29, 2024 16:39
@ivopascal
Copy link
Contributor Author

No matching distribution found for numpy>=2.0.0.dev0

I think https://anaconda.org/scientific-python-nightly-wheels/ is experiencing some hick-ups, as nothing from numpy is showing there. The pipelines of other PRs were able to pull from there just fine 12 hours ago.

@ivopascal ivopascal marked this pull request as ready for review March 1, 2024 09:43
@ivopascal ivopascal requested a review from larsoner as a code owner March 1, 2024 09:43
@ivopascal
Copy link
Contributor Author

Ah, it's a known problem numpy/numpy#25907

@matthewfeickert
Copy link

@ivopascal Please retrigger the CI given numpy/numpy#25907 (comment).

@larsoner
Copy link
Member

larsoner commented Mar 1, 2024

We will once numpy/numpy#25907 (comment) is fixed :)

@larsoner larsoner added this to the 1.7 milestone Apr 15, 2024
@larsoner larsoner enabled auto-merge (squash) April 15, 2024 15:27
mne/viz/raw.py Outdated Show resolved Hide resolved
@larsoner larsoner merged commit 5af2dd7 into mne-tools:main Apr 15, 2024
30 checks passed
Copy link

welcome bot commented Apr 15, 2024

🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪

larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 16, 2024
* upstream/main:
  fix prefilter management for EDF/BDF (mne-tools#12441)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12541)
  ENH: Allow removal of (up to two) bad marker coils in read_raw_kit() (mne-tools#12394)
  Implement `picks` argument to `Raw.plot()` (mne-tools#12467)
  Add Meggie under Related Software documentation (mne-tools#12540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants