Fix EDF/BDF filter warning bug #12661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrnr
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
|
Nice, thanks @cbrnr ! We'll get to see if the backport bot does its job just based on the added label, too 🤞 |
meeseeksmachine
pushed a commit
to meeseeksmachine/mne-python
that referenced
this pull request
Jun 14, 2024
larsoner
added a commit
that referenced
this pull request
Jun 14, 2024
…g) (#12666) Co-authored-by: Clemens Brunner <[email protected]> Co-authored-by: Eric Larson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the most urgent issue in #12643. The warning was incorrectly emitted because there was a bug with iterating over selected channel indices.
Note that I still don't know if the behavior is actually correct or not, so this needs to be fixed in a follow-up PR. However, fixing the warning is more important, and I'd appreciate if we pushed a hotfix release with a backport soon.