Solving issue #13122: Aiming to achieve better sensitivity of head movement detection for chpi extraction #13123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
|
Can you add a and then add your name + url to |
shresth-keshari
requested review from
larsoner,
drammock,
agramfort and
dengemann
as code owners
larsoner
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Looks good to me, marking for merge-when-green and approved the CI run. Thanks in advance @shresth-keshari !
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
Thank you so much, @larsoner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #13122 👍 : Insufficiently sensitive head movement detection for chpi extraction.
What does this implement/fix?
This implement fixes the issue of waiting for all the head coordinates to change from a previous frame in order to detect change. It'll now detect changes even for any head coordinate changes.
Changes were made according to the requirement in the issue. { np.all --> np.any }
Additional information
This is my first PR to MNE-Python repository, aimed towards contributing in GSOC'25.
Please let me know if there are any further requirement for changes in the current implementation..