Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Refactor EDF channel picking #5137

Merged
merged 1 commit into from
Apr 18, 2018
Merged

MRG: Refactor EDF channel picking #5137

merged 1 commit into from
Apr 18, 2018

Conversation

larsoner
Copy link
Member

@cbrnr to tackle #1766 I first want to refactor the EDF reader to hold a "sel" of the channels to be used. Can you see if this breaks anything with your set of EDF data files? Tests are passing at least.

@larsoner larsoner changed the title MRG: Pick raw channels without preload MRG: Refactor EDF channel picking Apr 16, 2018
@cbrnr
Copy link
Contributor

cbrnr commented Apr 17, 2018

All good. However, note that if there is a TAL channel, data must be preloaded (otherwise you get this RuntimeError: EDF+ Annotations (TAL) channel needs to be parsed completely on loading. You must set preload parameter to True.). I'm not sure if this is relevant for what you want to do.

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #5137 into master will decrease coverage by <.01%.
The diff coverage is 98.07%.

@@            Coverage Diff             @@
##           master    #5137      +/-   ##
==========================================
- Coverage   88.14%   88.14%   -0.01%     
==========================================
  Files         357      357              
  Lines       65777    65765      -12     
  Branches    11192    11185       -7     
==========================================
- Hits        57982    57970      -12     
  Misses       4958     4958              
  Partials     2837     2837

@larsoner
Copy link
Member Author

It won't really be relevant fortunately

@agramfort
Copy link
Member

@cbrnr feel free to merge then.

@cbrnr
Copy link
Contributor

cbrnr commented Apr 17, 2018

@agramfort I don't have the permission to merge, but you guys go ahead, my test files can still be loaded!

@agramfort
Copy link
Member

@cbrnr now you should be able to merge :)

@cbrnr cbrnr merged commit 1dc1502 into mne-tools:master Apr 18, 2018
@cbrnr
Copy link
Contributor

cbrnr commented Apr 18, 2018

Thanks @agramfort, I'm happy to be part of the team! Thanks @larsoner, PR merged.

@larsoner larsoner deleted the pick branch April 18, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants