MRG: Add support for fNIRS NIRStar v15.0 files #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Oct 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #6986 +/- ##
========================================
Coverage ? 89.7%
========================================
Files ? 430
Lines ? 77024
Branches ? 12531
========================================
Hits ? 69095
Misses ? 5132
Partials ? 2797 |
rob-luke
force-pushed
the
fnirs-nirstar-15.0
branch
from
b9cf1b1 to
30abfde
Compare
rob-luke
changed the title
|
@larsoner and @agramfort this is now ready for review/merge. Thanks |
|
I also rethought the way short channels are positioned, and am now using the source location. I think this makes most sense, as the short channels are positioned as close to sources as possible by definition. Also adding a constant offset assumed we knew in what direction the offset was, which we dont. |
|
Nice, looks more readable to me now. Thanks @rob-luke ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Adds support for reading NIRX NIRStar version 15.0 files.
Additional information
This PR is dependent on mne-tools/mne-testing-data#56 being merged. Then the testing version needs to be incremented in this PR.