Add clear_points in _TimeViewer #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Mar 4, 2020
agramfort
reviewed
Mar 4, 2020
| @@ -744,6 +753,7 @@ def help(self): | |||
| ('i', 'Toggle interface'), | |||
| ('s', 'Apply auto-scaling'), | |||
| ('r', 'Restore original clim'), | |||
| ('c', 'Clear all traces'), | |||
There was a problem hiding this comment.
pressing c is not working for me. Did you forget to configure the callback?
There was a problem hiding this comment.
also pressing i or s does not work anymore for me :(
There was a problem hiding this comment.
Did you try with pyvista 0.23.1?
There was a problem hiding this comment.
This is now the recommended version:
#7162 (comment)
|
great it works with 0.23.1 !
+1 for MRG !
… |
86 tasks
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a shortcut
cto clear all traces, the help window is also updated.Here is an animation with
show_traces='separate':It's an item of #7162