Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Remove toolbars in PyVista plotter #7572

Merged
merged 2 commits into from
Apr 7, 2020
Merged

MRG: Remove toolbars in PyVista plotter #7572

merged 2 commits into from
Apr 7, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Apr 7, 2020 •
edited
Loading

This small PR disables the default camera toolbars which are not compatible with _TimeViewer. Its features are either unused or duplicated.

This simplifies the window design overall.

master PR
image image

@GuillaumeFavelier GuillaumeFavelier self-assigned this Apr 7, 2020
@agramfort
Copy link
Member

@hoechenberger ok for you?

@GuillaumeFavelier GuillaumeFavelier changed the title Remove toolbars in PyVista plotter MRG: Remove toolbars in PyVista plotter Apr 7, 2020
@hoechenberger
Copy link
Member

hoechenberger commented Apr 7, 2020 •
edited
Loading

Works for me. It's a little jumpy because the window first opens with the toolbars, only to close them during the initialization process. But if that's the easiest way for you to do it, let's just leave it so.

@larsoner
Copy link
Member

larsoner commented Apr 7, 2020

It would indeed be nice to make this a PyVista on-window-instantiation option (i.e., have it never show up at all). @GuillaumeFavelier want to make an upstream PR that avoids this jerkiness in the long term?

@GuillaumeFavelier
Copy link
Contributor Author

want to make an upstream PR that avoids this jerkiness in the long term?

I'll take care of it!

@GuillaumeFavelier
Copy link
Contributor Author

I opened pyvista/pyvista#667

But meanwhile I think closing the toolbar is the nicest way to achieve this.

@larsoner
Copy link
Member

larsoner commented Apr 7, 2020

Agreed, and once 0.25 is out we can add some _get_args introspection to figure out if we can remove during instantiation (0.25+) or if we need to remove after the fact (0.24)

@larsoner larsoner merged commit ab50b23 into mne-tools:master Apr 7, 2020
@larsoner
Copy link
Member

larsoner commented Apr 7, 2020

Thanks @GuillaumeFavelier

@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Apr 8, 2020
Merged
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 10, 2020
@larsoner
Merge remote-tracking branch 'upstream/master' into cola
002bd0a 
* upstream/master: (1522 commits)
  FIX: Show bug
  MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581)
  DOC: Simplify Darwin installation (mne-tools#7584)
  MRG, ENH: Allow picking without preload (mne-tools#7507)
  DOC: Document anonymization better (mne-tools#7587)
  Rework _Brain show (mne-tools#7580)
  DOC: Fixes in tutorial (mne-tools#7579)
  ENH: muscle artifact detection (mne-tools#7407)
  MRG: Remove toolbars in PyVista plotter (mne-tools#7572)
  WIP: Deregister plotter from the figure list in close() (mne-tools#7573)
  MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563)
  FIX: Fix toggle all (mne-tools#7567)
  MRG, FIX: parallel n_jobs check (mne-tools#7566)
  Rename artifact detection to movement detection (mne-tools#7569)
  ENH: Update spelling check [ci skip] (mne-tools#7565)
  MRG, ENH: Dont require preload for raw resample (mne-tools#7508)
  MRG: Add interpolation for NIRS signals (mne-tools#7428)
  WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556)
  DOC: fix link in docstr [skip ci] (mne-tools#7562)
  ENH: Custom figure title when plotting Dipole locations (mne-tools#7558)
  ...
@GuillaumeFavelier GuillaumeFavelier deleted the pyvista_close_toolbar branch June 11, 2020 09:43
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
@larsoner
Merge remote-tracking branch 'upstream/master' into cola
04dabfd 
* upstream/master: (1522 commits)
  FIX: Show bug
  MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581)
  DOC: Simplify Darwin installation (mne-tools#7584)
  MRG, ENH: Allow picking without preload (mne-tools#7507)
  DOC: Document anonymization better (mne-tools#7587)
  Rework _Brain show (mne-tools#7580)
  DOC: Fixes in tutorial (mne-tools#7579)
  ENH: muscle artifact detection (mne-tools#7407)
  MRG: Remove toolbars in PyVista plotter (mne-tools#7572)
  WIP: Deregister plotter from the figure list in close() (mne-tools#7573)
  MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563)
  FIX: Fix toggle all (mne-tools#7567)
  MRG, FIX: parallel n_jobs check (mne-tools#7566)
  Rename artifact detection to movement detection (mne-tools#7569)
  ENH: Update spelling check [ci skip] (mne-tools#7565)
  MRG, ENH: Dont require preload for raw resample (mne-tools#7508)
  MRG: Add interpolation for NIRS signals (mne-tools#7428)
  WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556)
  DOC: fix link in docstr [skip ci] (mne-tools#7562)
  ENH: Custom figure title when plotting Dipole locations (mne-tools#7558)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
VIZ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeFavelier @agramfort @hoechenberger @larsoner