Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Check Circle #7596

Merged
merged 3 commits into from
Apr 10, 2020
Merged

TST: Check Circle #7596

merged 3 commits into from
Apr 10, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

This PR follows #7574 (comment) and tries to reproduce the warnings.

@GuillaumeFavelier GuillaumeFavelier self-assigned this Apr 10, 2020
@GuillaumeFavelier
Copy link
Contributor Author

Okay so I'm able to reproduce on master but I swim in very dark waters here. From what I can decipher, STIM channel and hpi are not registered in a certain glossary.

@GuillaumeFavelier GuillaumeFavelier marked this pull request as ready for review April 10, 2020 17:49
@GuillaumeFavelier
Copy link
Contributor Author

I suppose those two terms should be added in doc/glossary.rst

@GuillaumeFavelier
Copy link
Contributor Author

Actually stim channel already exists so it could be an issue with case-sensitive stuff.

@larsoner
Copy link
Member

Yes we build with --pre releases of Sphinx nowadays to catch these bugs early

@larsoner larsoner merged commit 8aa26ac into mne-tools:master Apr 10, 2020
@larsoner
Copy link
Member

Thanks @GuillaumeFavelier

larsoner pushed a commit that referenced this pull request Apr 17, 2020
@GuillaumeFavelier @larsoner
TST: Check Circle (#7596)
676db82 
* TST: Trigger Circle [skip travis][skip azp]

* Fix stim channel case in tutorials

* TST: Fix hpi case in tutorials
@GuillaumeFavelier GuillaumeFavelier deleted the check_circle branch June 11, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeFavelier @larsoner