-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG, FIX: Check reject_by_annotation in ica.plot_properties #8103
Conversation
can you update or add a test @yh-luo ? |
@agramfort I will work on it! |
991192a
to
7779b95
Compare
The bug is actually caused by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can you see why CIs are failing?
code looks good !
mne/epochs.py
Outdated
reject_by_annotation : bool | ||
Whether to reject based on annotations. If ``True`` (default), epochs | ||
overlapping with segments whose description begins with ``'bad'`` are | ||
rejected. If ``False``, no rejection based on annotations is performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you factorize this docstring using docdict to avoid a copy paste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of functions duplicate the documentation of reject_by_annotation
. I updated most of them too (except those default to False
).
CircleCI can be ignored, it's fixed by #8109 (will restart once that's merged) |
@yh-luo please add a what's new entry and then +1 for MRG. thx |
Thanks @yh-luo ! |
Fix #8101 .
Because
reject_by_annotation
inica.fit()
defaults toTrue
, reconstruction of source inplot_properties
should take care of that or the error occurs due to the incorrect number of epochs.TODO
ica.plot_properties
make_fixed_length_epochs
reject_by_annotation
using docdictBefore this PR
After adding annotations
After this PR
Before adding annotations
After adding annotations
This PR fixes the bug and the results are not influenced.