Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for new sklearn #8373

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fixes for new sklearn #8373

merged 1 commit into from
Oct 15, 2020

Conversation

agramfort
Copy link
Member

decovered as working on sklearn master

larsoner
larsoner approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SciPy 1.1 was released over 2 years ago so we might consider also bumping our version req to 1.1 (then we don't need that orth fix at all)

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.9 label Oct 15, 2020
@agramfort
Copy link
Member Author

floor is yours @larsoner :)

@larsoner larsoner merged commit db510cc into mne-tools:master Oct 15, 2020
larsoner pushed a commit that referenced this pull request Oct 15, 2020
@agramfort @larsoner
fixes for new sklearn (#8373)
7a46ddb
@larsoner larsoner deleted the fixes_new_sklearn branch October 15, 2020 12:26
@larsoner larsoner restored the fixes_new_sklearn branch October 15, 2020 12:26
@larsoner larsoner added backported and removed backport-candidate on-merge: backport to maint/1.9 labels Oct 15, 2020
@larsoner
Copy link
Member

Backported, thanks @agramfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

Assignees
No one assigned
Labels
backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agramfort @larsoner