Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: separate MPL canvas #8408

Merged
merged 1 commit into from
Oct 23, 2020
Merged

FIX: separate MPL canvas #8408

merged 1 commit into from
Oct 23, 2020

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Oct 23, 2020 •
edited
Loading

This PR fixes the issue of stc.plot whith show_traces='separate'.

@GuillaumeFavelier GuillaumeFavelier self-assigned this Oct 23, 2020
agramfort
agramfort approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol 😂

@larsoner
Copy link
Member

So apparently we have some coverage lapse :)

Can you add a test that would have caught this?

@hoechenberger
Copy link
Member

Lol 😂

Yes that's what we thought ;)

@agramfort agramfort merged commit 86db55a into mne-tools:master Oct 23, 2020
@larsoner
Copy link
Member

I'd still like a test to prevent this from happening in the future...

@GuillaumeFavelier
Copy link
Contributor Author

I'll add one!

@GuillaumeFavelier GuillaumeFavelier deleted the fix_separate_canvas branch October 23, 2020 13:26
larsoner added a commit to adam2392/mne-python that referenced this pull request Oct 23, 2020
@larsoner
Merge remote-tracking branch 'upstream/master' into seeg
0d4ce38 
* upstream/master:
  Fix separate canvas (mne-tools#8408)
  FIX: focalpoint (mne-tools#8405)
  WIP: Refs (mne-tools#8406)
  tiny cosmetic improvements to BEM code (mne-tools#8404)
  MRG, ENH: Fix memory on CircleCI (mne-tools#8379)
  MRG: Update backend parameter in stc.plot() (mne-tools#8395)
@GuillaumeFavelier GuillaumeFavelier mentioned this pull request Oct 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

@hoechenberger hoechenberger hoechenberger approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeFavelier @larsoner @hoechenberger @agramfort