Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw EGI MFF files with multiple epochs #37

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

rhancockn
Copy link
Contributor

Sample raw MFF files with multiple epochs. For mne-tools/mne-python#5373 and mne-tools/mne-python#4826.

@larsoner
Copy link
Member

How large are these files? Are they as small as possible to demonstrate/test the issue?

Here are two other datasets people posted for testing (from here and here):

mff with pause.zip
test_pause_EGI.zip

They are each < 200 kB compressed. If they are smaller than yours and demonstrate the same issue, perhaps we should use them instead? If not, maybe we should add all 3 for completeness? WDYT?

@larsoner
Copy link
Member

(note: if you do switch to these, please uncompress them before adding them -- git will take care of properly compressing the commit)

@mmagnuski
Copy link
Member

@larsoner The bin file here is 3.82 MB according to github so I think it may be acceptable. As far as I remember the files you link to contain pauses but not events so they are not sufficient to demonstrate the misalignment bug. At least that should be the case for the file I posted, but the other file was linked via wetransfer that has expired.

@larsoner
Copy link
Member

larsoner commented Apr 9, 2020

@mmagnuski where is the file you posted that has events? That plus the file here might be good enough for debugging

@mmagnuski
Copy link
Member

I'll take a look, I don't remember very well which file it was, and correspondingly where it is now. But I have some big files that due to the problems with events in mff files with puases do not have erps :) Correct realignment of the events brings the erps back.

@rhancockn
Copy link
Contributor Author

rhancockn commented Apr 9, 2020 via email

@larsoner
Copy link
Member

larsoner commented Apr 9, 2020

This does indeed have events, let's get it in -- thanks @rhancockn

@larsoner larsoner merged commit 7e97c83 into mne-tools:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants