fix: component icons will no longer be displayed in the scene view

mob-sakai · Feb 21, 2025 · 6dfbdae · 6dfbdae
1 parent b63220b
commit 6dfbdae
Show file tree

Hide file tree

Showing 8 changed files with 65 additions and 6 deletions.
diff --git a/Packages/src/Runtime/Internal/Extensions/ComponentExtensions.cs b/Packages/src/Runtime/Internal/Extensions/ComponentExtensions.cs
@@ -204,7 +204,7 @@ internal static void ConvertTo<T>(this Object context) where T : MonoBehaviour
             target.enabled = false;
 
             // Find MonoScript of the specified component.
-            foreach (var script in Resources.FindObjectsOfTypeAll<MonoScript>())
+            foreach (var script in MonoImporter.GetAllRuntimeMonoScripts())
             {
                 if (script.GetClass() != typeof(T))
                 {

diff --git a/Packages/src/Runtime/Internal/Utilities/Misc.cs b/Packages/src/Runtime/Internal/Utilities/Misc.cs
@@ -3,11 +3,16 @@
 using UnityEditor;
 using UnityEngine;
 using Object = UnityEngine.Object;
-#if UNITY_EDITOR && UNITY_2021_2_OR_NEWER
+#if UNITY_EDITOR
+using System.IO;
+using System.Linq;
+using System.Reflection;
+#if UNITY_2021_2_OR_NEWER
 using UnityEditor.SceneManagement;
-#elif UNITY_EDITOR
+#else
 using UnityEditor.Experimental.SceneManagement;
 #endif
+#endif
 
 namespace Coffee.UIParticleInternal
 {
@@ -72,5 +77,56 @@ public static T[] GetAllComponentsInPrefabStage<T>() where T : Component
 
         public static bool isBatchOrBuilding => Application.isBatchMode || BuildPipeline.isBuildingPlayer;
 #endif
+
+        [Conditional("UNITY_EDITOR")]
+        public static void QueuePlayerLoopUpdate()
+        {
+#if UNITY_EDITOR
+            if (!EditorApplication.isPlaying)
+            {
+                EditorApplication.QueuePlayerLoopUpdate();
+            }
+#endif
+        }
     }
+
+#if !UNITY_2021_2_OR_NEWER
+    [AttributeUsage(AttributeTargets.Class)]
+    [Conditional("UNITY_EDITOR")]
+    internal class IconAttribute : Attribute
+    {
+        private readonly string _path;
+
+        public IconAttribute(string path)
+        {
+            _path = path;
+        }
+
+#if UNITY_EDITOR
+        private static Action<Object, Texture2D> s_SetIconForObject = typeof(EditorGUIUtility)
+            .GetMethod("SetIconForObject", BindingFlags.Static | BindingFlags.NonPublic)
+            .CreateDelegate(typeof(Action<Object, Texture2D>), null) as Action<Object, Texture2D>;
+
+        [InitializeOnLoadMethod]
+        private static void InitializeOnLoadMethod()
+        {
+            if (Misc.isBatchOrBuilding) return;
+
+            var types = TypeCache.GetTypesWithAttribute<IconAttribute>();
+            var scripts = MonoImporter.GetAllRuntimeMonoScripts();
+            foreach (var type in types)
+            {
+                var script = scripts.FirstOrDefault(x => x.GetClass() == type);
+                if (!script) continue;
+
+                var path = type.GetCustomAttribute<IconAttribute>()?._path;
+                var icon = AssetDatabase.LoadAssetAtPath<Texture2D>(path);
+                if (!icon) continue;
+
+                s_SetIconForObject(script, icon);
+            }
+        }
+#endif
+    }
+#endif
 }
diff --git a/Packages/src/Runtime/UIParticle.cs b/Packages/src/Runtime/UIParticle.cs
@@ -17,6 +17,7 @@ namespace Coffee.UIExtensions
     /// <summary>
     /// Render maskable and sortable particle effect ,without Camera, RenderTexture or Canvas.
     /// </summary>
+    [Icon("Packages/com.coffee.ui-particle/Icons/UIParticleIcon.png")]
     [ExecuteAlways]
     [RequireComponent(typeof(RectTransform))]
     [RequireComponent(typeof(CanvasRenderer))]

diff --git a/Packages/src/Runtime/UIParticle.cs.meta b/Packages/src/Runtime/UIParticle.cs.meta
diff --git a/Packages/src/Runtime/UIParticleProjectSettings.cs b/Packages/src/Runtime/UIParticleProjectSettings.cs
@@ -5,6 +5,7 @@
 
 namespace Coffee.UIExtensions
 {
+    [Icon("Packages/com.coffee.ui-particle/Icons/UIParticleIcon.png")]
     public class UIParticleProjectSettings : PreloadedProjectSettings<UIParticleProjectSettings>
     {
         [Header("Setting")]

diff --git a/Packages/src/Runtime/UIParticleProjectSettings.cs.meta b/Packages/src/Runtime/UIParticleProjectSettings.cs.meta
diff --git a/Packages/src/Runtime/UIParticleRenderer.cs b/Packages/src/Runtime/UIParticleRenderer.cs
@@ -15,6 +15,7 @@
 
 namespace Coffee.UIExtensions
 {
+    [Icon("Packages/com.coffee.ui-particle/Icons/UIParticleIcon.png")]
     [ExecuteAlways]
     [RequireComponent(typeof(RectTransform))]
     [RequireComponent(typeof(CanvasRenderer))]

diff --git a/Packages/src/Runtime/UIParticleRenderer.cs.meta b/Packages/src/Runtime/UIParticleRenderer.cs.meta