Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Fix issue where document.writing out the combo code fails in firefox #227

Merged
merged 2 commits into from
Jan 9, 2014

Conversation

tedtate
Copy link
Contributor

@tedtate tedtate commented Nov 20, 2013

  • due to uglify mangling our literals.

@tedtate
Copy link
Contributor Author

tedtate commented Nov 20, 2013

@noahadams @rrjamie

@hallvors
Copy link

hallvors commented Jan 6, 2014

Thanks for fixing this, it's one of the issues that breaks Wired.com in Firefox for Android: https://bugzilla.mozilla.org/show_bug.cgi?id=923360#c10
I still haven't fully understood these problems, so if you have hints or debug tips, comments in that bug are welcome!

@hallvors
Copy link

hallvors commented Jan 7, 2014

PS - I hope you can backport this fix to older version too
CC @jansepar

@jansepar
Copy link
Contributor

jansepar commented Jan 7, 2014

Sorry, this actually fixes the issue in the version Wired is using. It needs to be also added to 2.0 :). I'm making a ticket so that we can address this ASAP.

rrjamie pushed a commit that referenced this pull request Jan 9, 2014
Fix issue where document.writing out the combo code fails in firefox
@rrjamie rrjamie merged commit 6505232 into v1.1 Jan 9, 2014
@hallvors
Copy link

@jansepar, @rrjamie : when we at Mozilla's site compatibility team find sites with the broken version, I'd like to be able to give specific advice like "please update mobify.js to version x.y or later". Could you let me know what version(s) this fix is shipping in?

(Context: Moz bug 984126)

@rrjamie
Copy link

rrjamie commented Mar 17, 2014

Hey Hallvors,

This fix landed in our mobify-client build tool in version 0.3.29 (see https://github.com/mobify/mobify-client/blob/master/CHANGELOG).

Users are automatically notified to update when the upload their work to Mobify Cloud, so people generally update quickly (though they will have to rebuild their site and deploy a new build for the fix).

If you notice any issues on a mobify.js powered site on Firefox, don't hesitate to let us know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants