Skip to content

Commit

Permalink
add xcode 12 check (#1673)
Browse files Browse the repository at this point in the history
Soundtrack of this PR: [Bok Bok - Papaya Lipgloss](https://youtu.be/MsIBb8IhF6Q)

### Motivation

`mobilecoin/libmobilecoin` will make static libraries that return `BadSignature` errors if "compiled with Xcode 13". Adding a check in the Makefile stops the problem early.

### In this PR
* Check that the version of Xcode `xcode-select`  is pointing to is version 12

Output if the user has Xcode 13 selected
```bash
$ sudo xcode-select -s /Applications/Xcode.app/Contents/Developer                                                                                                                                                                                                                                              
$ make                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             
profile: mobile-release
"Checking selected Xcode is version 12"
xcodebuild -version | grep 'Xcode 12'
make: *** [setup] Error 1
```

### Future Work
* Fix underlying issue
  • Loading branch information
the-real-adammork authored Mar 25, 2022
1 parent de6f3f1 commit e648990
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions libmobilecoin/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ bitcode-init:

.PHONY: setup
setup:
$(info "Checking selected Xcode is version 12")
xcodebuild -version | grep 'Xcode 12'
mkdir -p rust-bitcode
cd rust-bitcode && \
git init && \
Expand Down

0 comments on commit e648990

Please sign in to comment.