Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BackfillingStream #1672

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add BackfillingStream #1672

merged 1 commit into from
Apr 6, 2022

Conversation

remoun
Copy link
Contributor

@remoun remoun commented Mar 18, 2022

Resolves #1604

@remoun remoun self-assigned this Mar 18, 2022
@remoun remoun linked an issue Mar 18, 2022 that may be closed by this pull request
Write a block stream multiplexer #1604
Closed
@remoun remoun force-pushed the block-streaming-backfill branch from f9e43c9 to 743d1f1 Compare March 21, 2022 18:50
@remoun remoun changed the title Add BlockFetcher and BackfillingStream Add BackfillingStream Mar 21, 2022
iamalwaysuncomfortable
iamalwaysuncomfortable approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, but thoughts on the details.

ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
@remoun remoun force-pushed the block-streaming-backfill branch from 743d1f1 to e62db5e Compare March 25, 2022 01:18
Base automatically changed from block-streaming-prefactor to feature/block-streaming March 30, 2022 17:20
@remoun remoun force-pushed the block-streaming-backfill branch from e62db5e to 967ead8 Compare March 30, 2022 17:34
iamalwaysuncomfortable
iamalwaysuncomfortable suggested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@iamalwaysuncomfortable iamalwaysuncomfortable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit about Arc creation location

ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
ledger/streaming/client/src/backfill.rs Show resolved Hide resolved
@iamalwaysuncomfortable
Copy link
Contributor

LGTM minus the one nit about arc, excited to get this merged

@remoun remoun requested a review from a team April 6, 2022 22:05
@remoun remoun merged commit b6ffce7 into feature/block-streaming Apr 6, 2022
@remoun remoun deleted the block-streaming-backfill branch April 6, 2022 22:57
remoun pushed a commit to remoun/mobilecoin that referenced this pull request Jul 11, 2022
Add BackfillingStream (mobilecoinfoundation#1672)
71fc9cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@integral-llc integral-llc integral-llc approved these changes

@iamalwaysuncomfortable iamalwaysuncomfortable iamalwaysuncomfortable approved these changes

@jcape jcape Awaiting requested review from jcape

Assignees

@remoun remoun

Labels
None yet
Projects
Blockchain Core
Archived in project
Milestone
(2022-Q1) Blockchain Consumers Go Fast
Development

Successfully merging this pull request may close these issues.

Write a block stream multiplexer
3 participants
@remoun @iamalwaysuncomfortable @integral-llc