-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decrement block version everywhere (master branch) #1700
Merged
cbeck88
merged 6 commits into
mobilecoinfoundation:master
from
cbeck88:decrement-block-version-master
Mar 28, 2022
Merged
decrement block version everywhere (master branch) #1700
cbeck88
merged 6 commits into
mobilecoinfoundation:master
from
cbeck88:decrement-block-version-master
Mar 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we have to decrement block version because of a compatibility issue it turns out that v1.0 always published block version = 0, and not one as the source code indicated after a bunch of development.
2 tasks
remoun
previously approved these changes
Mar 25, 2022
eranrund
previously approved these changes
Mar 25, 2022
remoun
previously approved these changes
Mar 25, 2022
iamalwaysuncomfortable
approved these changes
Mar 25, 2022
jcape
reviewed
Mar 28, 2022
eranrund
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have to decrement block version because of a compatibility issue
it turns out that v1.0 always published block version = 0, and not
one as the source code indicated after a bunch of development.
this was made by cherry-picking the fix from release 1.2 branch, then removing
BlockVerision::THREE
for now and fixing up a bunch of things in minting and ring signature logic and tests.