Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrement block version everywhere (master branch) #1700

Merged

Conversation

cbeck88
Copy link
Contributor

@cbeck88 cbeck88 commented Mar 25, 2022

we have to decrement block version because of a compatibility issue
it turns out that v1.0 always published block version = 0, and not
one as the source code indicated after a bunch of development.

this was made by cherry-picking the fix from release 1.2 branch, then removing BlockVerision::THREE for now and fixing up a bunch of things in minting and ring signature logic and tests.

we have to decrement block version because of a compatibility issue
it turns out that v1.0 always published block version = 0, and not
one as the source code indicated after a bunch of development.
@cbeck88 cbeck88 requested review from jcape, remoun, eranrund, integral-llc, sugargoat and a team March 25, 2022 16:04
@cbeck88 cbeck88 changed the title decrement block version everywhere decrement block version everywhere (master branch) Mar 25, 2022
remoun
remoun previously approved these changes Mar 25, 2022
ledger/db/src/lib.rs Outdated Show resolved Hide resolved
eranrund
eranrund previously approved these changes Mar 25, 2022
@cbeck88 cbeck88 dismissed stale reviews from eranrund and remoun via 48ad166 March 25, 2022 17:47
@cbeck88 cbeck88 requested review from remoun and eranrund March 25, 2022 17:53
remoun
remoun previously approved these changes Mar 25, 2022
@cbeck88 cbeck88 requested a review from remoun March 27, 2022 02:54
@cbeck88 cbeck88 merged commit 4561317 into mobilecoinfoundation:master Mar 28, 2022
@cbeck88 cbeck88 deleted the decrement-block-version-master branch March 28, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants