Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PaymentRequest and tests with paymentID #247

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Update PaymentRequest and tests with paymentID #247

merged 3 commits into from
Apr 25, 2023
+73 −31

Conversation

the-real-adammork
Copy link
Collaborator

Motivation

Add paymentID to payment request

In this PR

  • update PaymentRequest
  • update tests
  • increment version for release

Future Work

  • Merge in libmobilecoin release & mobilecoin release

carybakker
carybakker approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@carybakker carybakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@the-real-adammork the-real-adammork merged commit 540d7bd into master Apr 25, 2023
@the-real-adammork the-real-adammork deleted the adam/#184870780 branch April 25, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carybakker carybakker carybakker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-real-adammork @carybakker