Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Test Cache and Redesign of Deployment Tests #151

Merged
merged 10 commits into from
Aug 8, 2024

Conversation

movchan74
Copy link
Contributor

Summary:
This update removes the test cache from our testing infrastructure and introduces improvements to the deployment tests, simplifying and enhancing efficiency. The changes also include updates to the documentation to reflect these modifications.

Key Changes:

  1. Test Cache Removal:

    • The test cache has been completely removed from the codebase and repository.
    • All tests have been updated to eliminate the usage of test cache.
  2. Deployment Test Updates:

    • Redesigned deployment tests to be simpler and more efficient.
    • Deployment tests are automatically skipped if they require GPU and no GPU is available.
    • Replaced the Stable Diffusion deployment with a dummy deployment in test_haystack_component.py, which does not require a GPU.
    • Added environment variable SAVE_EXPECTED_OUTPUT to save the actual output as the expected output to simplify test creation.
  3. Documentation Updates:

    • All references to the test cache were removed from the documentation.
    • Added instructions for creating new deployment tests.

Closes: #146, #80
Invalidates: #82, #50

@movchan74 movchan74 self-assigned this Aug 8, 2024
Copy link
Contributor

@HRashidi HRashidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Remove Test Cache [ENHANCEMENT] Better Saving Mechanism for the Expected Results in Tests
3 participants