Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CSS modules #445

Closed
kachick opened this issue Jun 9, 2022 · 2 comments · Fixed by #446
Closed

Use CSS modules #445

kachick opened this issue Jun 9, 2022 · 2 comments · Fixed by #446
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kachick
Copy link
Member

kachick commented Jun 9, 2022 •
edited
Loading

We are using very simple names for CSS classes as a pure css.
I'm positive to use pure css for this project, However I always aflaid the conflict.

So replacing to CSS Modules is a reasonable way, I think.
No adding dependencies is needed, 991f0f5 is just the task.

It might be deprecated as a webpack-contrib/css-loader#1050 (comment), but still keeping less cost even if it will be dropped.
@kachick kachick added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2022
This was referenced Jun 9, 2022
Merged
Merged
@kachick
Copy link
Member Author

kachick commented Sep 1, 2022

@pankona FYI: https://developer.hatenastaff.com/entry/2022/09/01/093000

@pankona
Copy link
Member

pankona commented Sep 1, 2022

reading now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply CSS modules mobu-of-the-world/mobu
2 participants
@kachick @pankona