Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide footer with commit ref #444

Merged
merged 4 commits into from
Jun 9, 2022
Merged

Provide footer with commit ref #444

merged 4 commits into from
Jun 9, 2022

Conversation

kachick
Copy link
Member

@kachick kachick commented Jun 9, 2022

Resolves #436

footer-pc

foooter-mobile

footer-jump

😤

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kachick kachick requested a review from a team June 9, 2022 15:17

export default defineConfig({
build: {
outDir: "./build",
},
plugins: [react()],
define: {
APP_COMMIT_REF: JSON.stringify(commitRef),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commitRef is a string, but without stringify makes error 🤔

@@ -1,7 +1,7 @@
import "./footer.css";
import css from "./footer.module.css";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#445

@mobu-of-the-world/maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing commit ref in footer helps contributors
1 participant