PropTypes with observableRequiresReaction check

[hymm]

I tried enabling observableRequiresReaction, but it's erroring on the react proptype checks. i.e.

function Component({ value }) {
  return <div>{value}</div>;
}

Component.propTypes = {
  // the next line is causing a observableRequiresReaction warning, wrapping it in an action removes the warning.
  value: PropTypes.number.isRequired, 
}

Is there a better way of dealing with this other than wrapping the propType checker in an action?

[danielkcz]

Well, you should wrap the component to observer, that check is kinda correct here. If you are wrapping it later on export, that won't work imo.

[hymm]

Here's a codesandbox with the issue: https://codesandbox.io/s/lucid-merkle-5cw3z?file=/index.js. My earlier example wasn't the best.

[mweststrate]

This is a known issue, propTypes are checked outside the render. You can either use the propTypes provided by mobx-react, or ignore the warnings, or use a type checker instead of propTypes :)

…

On Fri, Nov 13, 2020 at 10:44 PM Mike ***@***.***> wrote: Here's a codesandbox with the issue: https://codesandbox.io/s/lucid-merkle-5cw3z?file=/index.js — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2621 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4NBCH6Q63D7V7MIM2WYTSPWZEHANCNFSM4TVCE6IA> .