-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor toJS #1699
Refactor toJS #1699
Conversation
Hey @wangyiz4262, I can't approve the change as-is, as this would break with the current behavior, producing different results. I'm fine though if this behavior is applied when a special flag is applied, for example: |
@mweststrate, thanks for the advice, will do! |
5c5739d
to
43ccdd9
Compare
Hi @mweststrate, I have added an optional flag as you suggested. Please check it out and merge if it is OK. Thanks! |
43ccdd9
to
56e2ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 👍 left some questions / comments
fix tests Fix some language inaccuracy
56e2ac2
to
c52b25e
Compare
Hi @mweststrate All comments have been addressed. And changes are also available for mobx4 in PR #1733 |
Thanks, merged! Will be part of next release |
Released as 5.5.1. Sorry for the late release! Missed that a PR was pending for release |
Thanks! :) |
PR checklist:
npm run perf
)toJS
will recursively convert an object containing Mobx observable value into a plain object