Fixes #2230 - computedvalue: throw error object instead of string when options is e… #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way I can unit test these changes? Any help appreciated! |
ramkumarvenkat
changed the title
danielkcz
reviewed
Dec 21, 2019
| @@ -105,8 +105,7 @@ export class ComputedValue<T> implements IObservable, IComputedValue<T>, IDeriva | |||
| * This is useful for working with vectors, mouse coordinates etc. | |||
| */ | |||
| constructor(options: IComputedValueOptions<T>) { | |||
| if (process.env.NODE_ENV !== "production" && !options.get) | |||
| throw "[mobx] missing option for computed: get" | |||
| invariant(options.get, "missing option for computed: get") | |||
There was a problem hiding this comment.
Let's keep [mobx] prefix there.
There was a problem hiding this comment.
|
Not sure about how to unit test this or if it's necessary. Update changelog, please. And also we will need another PR to |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mpty
Fixes #2230
PR checklist:
/docs. For new functionality, at leastAPI.mdshould be updatednpm run perf)