Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JSON formatted logs #3133

Closed
tavlima opened this issue Sep 26, 2022 · 6 comments · Fixed by #4044
Closed

Add support for JSON formatted logs #3133

tavlima opened this issue Sep 26, 2022 · 6 comments · Fixed by #4044
Labels
exp/beginner kind/enhancement

Comments

@tavlima
Copy link

tavlima commented Sep 26, 2022 •
edited
Loading

It would be great to have support for JSON formatted logs, perhaps with a new option in the buildkitd.toml to switch between the default TextFormatter in here and JSONFormatter (docs).
@moeghanem
Copy link

Hey, I am a student at the University of Texas at Austin, and I was wondering if I could work on this issue for my virtualization class! Thanks.

This was referenced Apr 27, 2023
Closed
Closed
chagui pushed a commit to chagui/buildkit that referenced this issue Jul 9, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
39a6b8b 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
chagui pushed a commit to chagui/buildkit that referenced this issue Jul 9, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
838d1eb 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
@chagui
Copy link
Contributor

chagui commented Jul 9, 2023

@moeghanem I would be more than happy to have JSON logs. I see a stale PR and am willing to help, anything blocking you?

@moeghanem
Copy link

@chagui Hi, yes, this was for a school project I had last semester. I believe I had completed the task at the time, but I am not too sure. It is referenced at #3824. If I recall, my issue was I had not squashed commits. Thanks!

@chagui
Copy link
Contributor

chagui commented Jul 9, 2023 •
edited
Loading

Nice, I cloned your fork and performed a rebase and squash operation. You can see the results on the comparison: https://github.com/moby/buildkit/compare/master...chagui:buildkit:master?expand=1
You should be able to do the same with your fork by fetching the latest from https://github.com/moby/buildkit master branch, then rebasing and squashing.
Feel free to DM me on Docker Community Slack if you need more pointers. Cheers!

@moeghanem
Copy link

@chagui Ah, so is there anything else that needs to be done regarding this?

@chagui
Copy link
Contributor

chagui commented Jul 10, 2023

@moeghanem yes. Git rebase, squash...oh my! will describe the process better than I can over the PR. The please-squash-your-commits section is the one relevant for your PR (#3824).

chagui pushed a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
3248009 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
@chagui chagui mentioned this issue Jul 20, 2023
Merged
chagui pushed a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
460b516 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
chagui pushed a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
5623955 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
chagui pushed a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@benjamin010095 @chagui
Add support for JSON formatted logs (moby#3133)
522e0a6 
Signed-off-by: Moe Ghanem <[email protected]>

added toml and flag functionality to buildkitd, fixed buildctl

Signed-off-by: Moe Ghanem <[email protected]>

removed toml from ctl

Signed-off-by: Moe Ghanem <[email protected]>

buildctl –opt flags documentation

Signed-off-by: Moe Ghanem <[email protected]>

updated with the properly toml and flag usage

Signed-off-by: Moe Ghanem <[email protected]>

changed "format" to "log-format", config struct

Signed-off-by: Moe Ghanem <[email protected]>
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
a7f6b61 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 20, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
1814f85 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 21, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
2eba46b 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 21, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
40486e9 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 22, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
6fe07a0 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 22, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
a878aa8 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 24, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
130177b 
Signed-off-by: Guilhem Charles <[email protected]>
chagui added a commit to chagui/buildkit that referenced this issue Jul 25, 2023
@chagui
Add support for JSON formatted logs (moby#3133)
5d15e36 
Signed-off-by: Guilhem Charles <[email protected]>
@jedevc jedevc linked a pull request Jul 27, 2023 that will close this issue
Add support for JSON formatted logs #4044
Merged
nxmatic pushed a commit to nxmatic/buildkit that referenced this issue Dec 3, 2023
@chagui @nxmatic
Add support for JSON formatted logs (moby#3133)
bbe1414 
Signed-off-by: Guilhem Charles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for JSON formatted logs chagui/buildkit
4 participants
@tonistiigi @chagui @tavlima @moeghanem