Allow sessions to hijack the connection outside of a solve #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edgar Lee <[email protected]>
Seems pretty common intermittent error. How do I get CI to rerun just that stage? |
|
@hinshun There is a "restart job" button |
|
Realized I wasn't logged in on Travis. The button shows up now, thanks. |
Signed-off-by: Edgar Lee <[email protected]>
hinshun
commented
Apr 8, 2020
| } | ||
| if len(opt.Exports) == 1 { | ||
| ex = opt.Exports[0] | ||
| } |
There was a problem hiding this comment.
The eventual call to Solve uses ex which isn't set if opt.SessionPreInitialized == true. Assigning ex = opt.Exports[0] shouldn't be related to whether the session is initialized yet or not.
AkihiroSuda
approved these changes
Apr 8, 2020
tonistiigi
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sessions need a way to run independently of a
Solveand that isn't possible without being to hijack the underlying GRPC connection of a BuildKit client.This a first step towards #1432, unblocking usage of shared sessions, but will require more design and implementation to support multiple sessions.