Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest update is the separation of
buildkit-containerd
andcontainer-runtime
stages that can be built into separate containers and used together like.@AkihiroSuda Do you have ideas for doing the
-v /tmp:/tmp:rshared
part better? It is needed for mounting the subpath in buildkit and using it in containerd. Apart from being ugly it doesn't work in docker4mac for example because it tries to mount tmp from osx(/var:/tmp
would work but create unexpected files).While testing this I once got an error
failed to prepare because parent doesn't exist
so I think there is still some issue with containerd gc. Related to #159Signed-off-by: Tonis Tiigi [email protected]