Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 remote cache #2323

Closed
wants to merge 1 commit into from
Closed

Add S3 remote cache #2323

wants to merge 1 commit into from

Conversation

sethpollack
Copy link

No description provided.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits

@sethpollack sethpollack force-pushed the s3_cache branch 2 times, most recently from c87225c to 79f140d Compare August 20, 2021 17:58
Signed-off-by: Seth Pollack <[email protected]>
@sethpollack
Copy link
Author

@AkihiroSuda anything else required for this PR?

@AkihiroSuda AkihiroSuda requested a review from tonistiigi August 27, 2021 14:22
@tonistiigi
Copy link
Member

How do we test it and make sure it doesn't randomly break? If there isn't an easy way to run a test without installing lots of (mock) dependencies or accounts, could you set up some external (open-source) testing that monitors the master branch.

@sethpollack Do we have an understanding that if we merge this, you will continue to maintain it, fix bugs if they are reported and keep it updated if changes are needed for overall cache system?

@crazy-max
Copy link
Member

If there isn't an easy way to run a test without installing lots of (mock) dependencies or accounts, could you set up some external (open-source) testing that monitors the master branch.

I wonder if we couldn't start a minimal MinIO container with GitHub Actions for integration tests.

@sethpollack
Copy link
Author

@tonistiigi I can work on adding the integration tests and I can help with maintaining it but can't commit to take full ownership of it.

@AkihiroSuda
Copy link
Member

Needs rebase

bpaquet pushed a commit to bpaquet/buildkit that referenced this pull request Apr 24, 2022
crafted from moby#2323
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 24, 2022
Largely inspired from moby#2323
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 24, 2022
Largely inspired from moby#2323
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 24, 2022
Largely inspired from moby#2323
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 25, 2022
Largely inspired from moby#2323
@bpaquet bpaquet mentioned this pull request Apr 25, 2022
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 25, 2022
Largely inspired from moby#2323
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 25, 2022
Largely inspired from moby#2323

Signed-off-by: Bertrand Paquet <[email protected]>
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 26, 2022
Largely inspired from moby#2323

Signed-off-by: Bertrand Paquet <[email protected]>
bpaquet added a commit to bpaquet/buildkit that referenced this pull request Apr 26, 2022
Largely inspired from moby#2323

Signed-off-by: Bertrand Paquet <[email protected]>
@sethpollack
Copy link
Author

closing in favor of #2824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants