-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 remote cache #2323
Add S3 remote cache #2323
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash commits
c87225c
to
79f140d
Compare
0ccf754
to
b3716a8
Compare
Signed-off-by: Seth Pollack <[email protected]>
@AkihiroSuda anything else required for this PR? |
How do we test it and make sure it doesn't randomly break? If there isn't an easy way to run a test without installing lots of (mock) dependencies or accounts, could you set up some external (open-source) testing that monitors the master branch. @sethpollack Do we have an understanding that if we merge this, you will continue to maintain it, fix bugs if they are reported and keep it updated if changes are needed for overall cache system? |
I wonder if we couldn't start a minimal MinIO container with GitHub Actions for integration tests. |
@tonistiigi I can work on adding the integration tests and I can help with maintaining it but can't commit to take full ownership of it. |
Needs rebase |
crafted from moby#2323
Largely inspired from moby#2323
Largely inspired from moby#2323
Largely inspired from moby#2323
Largely inspired from moby#2323
Largely inspired from moby#2323
Largely inspired from moby#2323 Signed-off-by: Bertrand Paquet <[email protected]>
Largely inspired from moby#2323 Signed-off-by: Bertrand Paquet <[email protected]>
Largely inspired from moby#2323 Signed-off-by: Bertrand Paquet <[email protected]>
closing in favor of #2824 |
No description provided.