add prune support and fix containerd gc #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
changed the title
|
This is ready for review now. |
AkihiroSuda
reviewed
Jan 4, 2018
cache/manager.go
Outdated
| @@ -69,42 +70,49 @@ func NewManager(opt ManagerOpt) (Manager, error) { | |||
| return cm, nil | |||
| } | |||
|
|
|||
| // init loads all snapshots from metadata state and tries to load the from the | |||
AkihiroSuda
reviewed
Jan 4, 2018
cache/manager.go
Outdated
| } | ||
|
|
||
| if cr.isDead() { | ||
| continue |
AkihiroSuda
reviewed
Jan 4, 2018
cache/refs.go
Outdated
| func (cr *cacheRecord) mref() *mutableRef { | ||
| ref := &mutableRef{cacheRecord: cr} | ||
| cr.refs[ref] = struct{}{} | ||
| return ref | ||
| } | ||
|
|
||
| // hold ref locak before calling |
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
|
@AkihiroSuda updated |
AkihiroSuda
approved these changes
Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25
fixes #159
Contrary to the original plan, I don't think anymore that (at least the current implementation) of leases are a good fit to BuildKit. Problem with leases is that they are hidden from the api and interfaces, hard to use in oci worker and because they only apply on creation they make it impossible for two users to share resources. Eg. one blob can't have 2 leases and I think this can cause broken pulls even on concurrent pulls with ctr.
Instead, I've created wrappers that make the create-delete model work again with the GC backed implementation so callers don't need to know the implementation differences of gc and labels. Managing the labels, instead of removing object also makes it easier to share data between build cache and exported resources.
Missing: