Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unbreak linter #3308

Merged
merged 2 commits into from
Nov 24, 2022
Merged

ci: unbreak linter #3308

merged 2 commits into from
Nov 24, 2022

Conversation

tonistiigi
Copy link
Member

Signed-off-by: Tonis Tiigi [email protected]

@@ -30,7 +29,7 @@ var LogsCommand = cli.Command{
func logs(clicontext *cli.Context) error {
args := clicontext.Args()
if len(args) == 0 {
return fmt.Errorf("build ref must be specified")
return errors.Errorf("build ref must be specified")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is fmt.Errorf deprecated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw errors.New seems suffice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkihiroSuda AkihiroSuda merged commit e8dac6c into moby:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants