exporter: force enabling inline attestations for image export #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <[email protected]>
Signed-off-by: Justin Chadwell <[email protected]>
jedevc
force-pushed
the
export-force-inline-attestation-image
branch
from
14dd214 to
3eaf157
Compare
tonistiigi
approved these changes
Jan 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @tonistiigi, we don't need the complexity of #3403, we just need to rework the behavior of inline attestations slightly.
localandtarexporters, never export inline attestationsocianddockerexporters, only export inline attestations if we are already exporting an image index (e.g. in the case of a multi-platform image, or if we have other attestations to export as well)imageexporter, always export inline attestations, forcing generation of an index even if we otherwise wouldn't.No corresponding buildx changes are necessary.