Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4100
Using an env var to set the otel socket path for the integration tests in #4078 requires to preserve the environment variables when using sudo for rootless mode but we can't use
-E
when we run a login shell (-i
).Specifying
BUILDKIT_TRACE_SOCKET
in buildkitArgs for oci and containerd workers in integration tests is tedious as tmpdir is not yet defined so I switched from an env var to a newotel-socket-path
flag for the buildkitd command. I took the opportunity to also set a new section in the TOML config if that makes sense. Let me know if you prefer a new PR for this or if the flag is enough.