fix: check snapshot labels to avoid panic #4187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a panic while using the stargz snapshotter caused by the labels being nil.
My wild-guess as to why labels is nil is that the stargz snapshotter could not find a bolt bucket:
https://github.com/containerd/containerd/blob/b0a7f08aa7490a3d43787b9f2b444e4b20b96f8c/metadata/boltutil/helpers.go#L53