[0.12] cherry-picks 0.12.4 #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit e99bfa9)
Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 7f8eedc)
The events for currently active builds were sent through pubsub channel instead of directly to the current request, like it was done for completed builds for example. This meant that if there are more active builds running than the pubsub channel buffer (32) the sends will block. Because the history API mutex is held in this process it will eventually block the requests for builds that try to update their history records. Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit 1ed9931)
When a record is marked for deletion the event is set to nil but we don't check if it's nil when sending events which could cause a panic. Signed-off-by: CrazyMax <[email protected]> (cherry picked from commit 9d39af0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports of: