Rule Check: CopyIgnoredFiles #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
force-pushed
the
copy-ignored-file-check
branch
4 times, most recently
from
735cbb4 to
d099d2d
Compare
tonistiigi
reviewed
Jul 8, 2024
| Description: "File is ignored by .dockerignore", | ||
| URL: "", | ||
| Format: func(file string) string { | ||
| return fmt.Sprintf("File %q is ignored by .dockerignore", file) |
There was a problem hiding this comment.
Ideally we could show the pattern that causes the issue but that might be tricky with current libs so can be left for follow-ups.
There was a problem hiding this comment.
Updated with more detail, and added the needs/follow-up flag. :)
daghack
force-pushed
the
copy-ignored-file-check
branch
3 times, most recently
from
87cb599 to
a8116c6
Compare
daghack
force-pushed
the
copy-ignored-file-check
branch
2 times, most recently
from
c5f2f48 to
92e5431
Compare
tonistiigi
reviewed
Jul 10, 2024
daghack
force-pushed
the
copy-ignored-file-check
branch
9 times, most recently
from
1882905 to
1986a33
Compare
tonistiigi
reviewed
Jul 10, 2024
daghack
force-pushed
the
copy-ignored-file-check
branch
4 times, most recently
from
9fa8d35 to
f52fe0b
Compare
tonistiigi
reviewed
Jul 10, 2024
daghack
force-pushed
the
copy-ignored-file-check
branch
3 times, most recently
from
71ac772 to
2abe516
Compare
tonistiigi
reviewed
Jul 10, 2024
daghack
force-pushed
the
copy-ignored-file-check
branch
3 times, most recently
from
277848b to
0783fd2
Compare
tonistiigi
approved these changes
Jul 10, 2024
daghack
force-pushed
the
copy-ignored-file-check
branch
from
0783fd2 to
e1f442b
Compare
|
…terns Signed-off-by: Talon Bowler <[email protected]> Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
copy-ignored-file-check
branch
from
e1f442b to
07fe324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to COPY/ADD files excluded by dockerignore will cause the build to fail because they are missing from the context. This adds a rule check to catch this case.