tests: frontend/dockerfile: add dockerfile lint tests for WCOW #5221
Conversation
github-actions
bot
added
area/dockerfile
area/testing
area/windows
area/frontend
area/util
labels
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
from
558b623 to
e4830ca
Compare
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
from
e4830ca to
2e92e16
Compare
|
PS. potential merge conflict with #5103 depending on which one lands first. |
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
from
2e92e16 to
586c206
Compare
|
rebased with the latest |
|
CI failure is unrelated, looks like we need to extend the timeout for the Linux tests too or what new thing could be causing the long waits? @crazy-max
|
Can you give the link to this github actions log? Can't find anything related to this for linux tests. |
@crazy-max -- my bad, this was meant for PR #5139 - https://github.com/moby/buildkit/actions/runs/10769264268/job/29860319420?pr=5139 |
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
from
586c206 to
7e89de8
Compare
| `) | ||
| `, | ||
| ` | ||
| FROM nanoserver AS base |
There was a problem hiding this comment.
For these Dockerfiles that only differ by the base image define baseImage := integration.UnixOrWindow() instead.
There was a problem hiding this comment.
I'd thought fmt.Sprintf will be a little ugly but let me fix that...
There was a problem hiding this comment.
Can also + integration.UnixOrWindow() + if that is cleaner
There was a problem hiding this comment.
Coz some come in between, might be better to use fmt.Sprintf. I've made here, and the other instances in the PR. PTAL.
| @@ -235,7 +235,7 @@ func init() { | |||
|
|
|||
| images := integration.UnixOrWindows( | |||
| []string{"busybox:latest", "alpine:latest"}, | |||
| []string{"nanoserver:latest", "nanoserver:plus"}) | |||
| []string{"nanoserver:latest", "nanoserver:plus", "nanoserver:plus-busybox"}) | |||
There was a problem hiding this comment.
Are you sure these are needed? I don't see busybox:stable ? @daghack
Maybe the test can be rewritten using different tagnames so that we don't need to pull more images just to check the tag string.
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
2 times, most recently
from
5c3c98c to
c5e8bb3
Compare
A number of integration tests were initially skipped on Windows, waiting for their platform-specific translations. See moby#4485. This commit enables all the dockerfile linter tests that had been skipped before. Some of the tests did not need any platform specific change since the lint warning were being generated before actual image pull. Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa
force-pushed
the
tests-4485-part-3-dockerfile-lint
branch
from
c5e8bb3 to
aa096eb
Compare
|
CI failure looks unrelated? |
A number of integration tests were initially skipped on Windows, waiting for their platform-specific translations. See #4485.
This commit enables all the dockerfile linter tests that had been skipped before. Some of the tests did not need any platform specific change since the lint warning were being generated before actual image pull.