Fix invalid index.json annotations on tar=false export #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
ociindex-annotations-fix
branch
from
7c1309b to
cb43103
Compare
tonistiigi
force-pushed
the
ociindex-annotations-fix
branch
2 times, most recently
from
5906c86 to
3dab3f3
Compare
tonistiigi
changed the title
|
cc @tianon Note that this is client-side fix. In order for this to change in buildx, vendor of buildkit needs to be updated there. |
AkihiroSuda
reviewed
Jan 6, 2025
| @@ -15,6 +17,8 @@ import ( | |||
| const ( | |||
| // lockFileSuffix is the suffix of the lock file | |||
| lockFileSuffix = ".lock" | |||
|
|
|||
| annotationImageName = "io.containerd.image.name" | |||
There was a problem hiding this comment.
This constant can be used https://github.com/containerd/containerd/blob/v2.0.1/core/images/annotations.go#L22
There was a problem hiding this comment.
I don't want to create a containerd dependency to this well-contained utility pkg.
AkihiroSuda
approved these changes
Jan 6, 2025
|
Needs rebase |
Signed-off-by: Tonis Tiigi <[email protected]>
Previous implementation mixed tags and names and added invalid comma-separated reference annotation. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
ociindex-annotations-fix
branch
from
3dab3f3 to
01cf0c6
Compare
AkihiroSuda
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5572