exporter: workaround containerd client issue with grpc size limits #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
containerd-grpc-size-limits
branch
from
8d99faf to
1caf5b4
Compare
tonistiigi
reviewed
Feb 27, 2025
The grpc client for containerd won't properly break up the writes for a file when used in combination with `bytes.NewReader` and `content.WriteBlob`. To workaround the issue, this wraps the container image exporter for containerd with a bytes reader that will chunk the `Write` calls instead of relying on the client to do the chunking. See containerd/containerd#11440 for the upstream containerd issue. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
containerd-grpc-size-limits
branch
from
1caf5b4 to
69d69b4
Compare
tonistiigi
approved these changes
Feb 27, 2025
|
@jsternberg I guess we don't need this and can just update containerd to v2.0.3 |
|
Going to close this in favor of just upgrading containerd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpc client for containerd won't properly break up the writes for a
file when used in combination with
bytes.NewReaderandcontent.WriteBlob.To workaround the issue, this wraps the container image exporter for
containerd with a bytes reader that will chunk the
Writecalls insteadof relying on the client to do the chunking.
See containerd/containerd#11440 for the
upstream containerd issue.
closes #5327