Make exported build cache deterministic #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
deterministic-cache
branch
from
a8c6ac3 to
e8b2ad1
Compare
AkihiroSuda
reviewed
Jan 11, 2019
tonistiigi
force-pushed
the
deterministic-cache
branch
2 times, most recently
from
903d919 to
9aeb0ae
Compare
AkihiroSuda
reviewed
Jan 15, 2019
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
deterministic-cache
branch
from
9aeb0ae to
ac4037a
Compare
AkihiroSuda
approved these changes
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #615 #777
Its possible there are still some edge cases that can be improved but these require extra debugging. This should cover most of it. Some cases where uploaded cache changes over time are by-design as if over time new metadata is determined that applies to same record, we want to upload that data as well.