boltdb/bolt==>bbolt, revendor Microsoft/*, Windows compilation.

[lowenna]

Signed-off-by: John Howard [email protected]

Almost fixes #1950.

Most of this PR is vendoring.

• I've bumped Microsoft/hcsshim and Microsoft/go-winio to the latest versions, which are the same as the ones currently vendored in the moby/moby repo.

• I've removed the unused syndtr/gocapability

• Replaced boltdb/bolt with go.etc.io/bbolt. Specifically because boltdb/bolt is no longer being maintained, and we need this fix Fix Windows flock/funlock race etcd-io/bbolt#122 to fix Saving endpoint to store fails in windows under concurrent load #1950. That was merged in https://github.com/etcd-io/bbolt/releases/tag/v1.3.1-etcd.8.

• I've also made go build ./… closer to building on Windows. I should really tackle vishvanada\netns one day as that's the next blocker for that. But not for this PR.

Once all this is merged, we need a follow-on PR to revendor libnetwork into moby/moby to finally fix #1950 (which should really be open in the moby/moby repo, but not important.)

@carlfischer1 FYI

@mavenugo PTAL

[lowenna]

Could someone help me understand what this failure might mean? Or help debug it? I'm not that familiar with libnetwork. Tentatively possible is a regression due to boltdb, purely based on supposition in that it has db in the name of the test.

--- FAIL: TestNetworkDBCRUDMediumCluster (16.92s)
	networkdb_test.go:112: Network existence verification failed
	networkdb_test.go:136: Entry existence verification test failed for node3(5e292e4e65e9)
	networkdb_test.go:136: Entry existence verification test failed for node3(5e292e4e65e9)
	networkdb_test.go:455: assertion failed: expression is false: strings.Contains(err.Error(), "deleted and pending garbage collection")

[lowenna]

I suspect this is a flaky test. It doesn't look like NetworkDB uses bolt (bbolt). On a second run, it failed in a different way:

=== RUN   TestNetworkDBCRUDMediumCluster
--- FAIL: TestNetworkDBCRUDMediumCluster (2.06s)
	networkdb_test.go:57: Number of nodes for node3 into the cluster does not match 5 != 4

I'll give it a third CI attempt...

[lowenna]

Ha, third time it passed. Pretty sure that's just a flaky test 😞

@thaJeztah FYI.

[mavenugo]

Yes. I dont know why and how networkdb fails for boltdb changes.
@fcrisciani might know more details on this.

[mavenugo]

LGTM

[thaJeztah]

Could you squash these three commits? Looks like they should go together;

• Bump libkv to 458977154600b9f23984d9f4b82e79570b5ae12b
• Remove github.com/boltdb/bolt from vendor.conf
• Vendor go.etcd.io/bbolt @ v1.3.1-etcd.8

[lowenna]

Could you squash these three commits?

@thaJeztah Done

[selansen]

LGTM

[thaJeztah]

LGTM

[thaJeztah]

thanks!

[lowenna]

Who can merge this? I'd really like to get the fix into moby/moby due to the number of people hitting the issue