Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/sys x/text vendoring #2302

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Conversation

alyyousuf7
Copy link
Contributor

CI is complaining about inconsistent vendors:
https://circleci.com/gh/docker/swarmkit/7629

Signed-off-by: Ali Yousuf [email protected]

@codecov
Copy link

codecov bot commented Jul 11, 2017

Codecov Report

Merging #2302 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
+ Coverage   61.06%   61.07%   +<.01%     
==========================================
  Files         128      128              
  Lines       20550    20550              
==========================================
+ Hits        12549    12550       +1     
+ Misses       6630     6618      -12     
- Partials     1371     1382      +11

@alyyousuf7 alyyousuf7 changed the title Update x/sys/unix, x/text/{internal,unicode} vendoring Update x/sys x/text vendoring Jul 11, 2017
@ijc
Copy link
Contributor

ijc commented Jul 11, 2017

#2299 hit this issue in CI too, I think vndr has been updated. We should perhaps consider following what moby/moby and now docker/cli#318 are doing and pin to a specific version of vndr?

@aaronlehmann
Copy link
Collaborator

LGTM

We should perhaps consider following what moby/moby and now docker/cli#318 are doing and pin to a specific version of vndr?

Seems like a good idea as long as we are proactive about keeping the pinned version up to date.

@aaronlehmann aaronlehmann merged commit df54e4f into moby:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants